Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task job mgr: use broadcast_mgr.get_updated_rtconfig interface #6352

Merged
merged 1 commit into from
Oct 1, 2024
Merged

task job mgr: use broadcast_mgr.get_updated_rtconfig interface #6352

merged 1 commit into from
Oct 1, 2024

Conversation

oliver-sanders
Copy link
Member

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
task job mgr: use broadcast_mgr.get_updated_rtconfig interface
17e5a6d 
* Spotted whilst reviewing cylc#6330
* Replace duplicated logic with a centralised implementation.
@oliver-sanders oliver-sanders added this to the 8.4.0 milestone Sep 3, 2024
@oliver-sanders oliver-sanders self-assigned this Sep 3, 2024
wxtim
wxtim approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More centralization of the broadcast logic please 👍🏼

(Happy for you to add a second reviewer or to merge)

@oliver-sanders oliver-sanders merged commit 5a37795 into cylc:master Oct 1, 2024
26 of 27 checks passed
@oliver-sanders oliver-sanders deleted the remove-duplicated-broadcast-logic branch October 1, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
8.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @wxtim